Emit export errors to stderr to prevent invalid output #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid. Fixes python-poetry#4109
1 task
finswimmer
requested changes
Jun 4, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixed! I noted that when I ran tests with |
|
@finswimmer This is a simple one, good to merge? Your requested change has been addressed, the remaining test failure looks unrelated ("connection reset by peer") |
|
@colindean: Could you please rebase your branch, to force the checks to run again? |
|
Checks are running now! |
finswimmer
approved these changes
Sep 3, 2021
1nF0rmed
pushed a commit
to 1nF0rmed/poetry
that referenced
this pull request
Nov 15, 2021
…#4110) * Emit export errors to stderr to prevent invalid output An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid. Fixes python-poetry#4109 * Looks at stderr for export tests
edvardm
pushed a commit
to edvardm/poetry
that referenced
this pull request
Nov 24, 2021
…#4110) * Emit export errors to stderr to prevent invalid output An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid. Fixes python-poetry#4109 * Looks at stderr for export tests
Merged
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid.
Pull Request Check List
Resolves: #4109
N.b. I made this change in GitHub so I did not run tests or add tests to ensure the bad behavior doesn't happen.