Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a solution for using passwords that start with a dash #4552

Merged
merged 5 commits into from
Nov 14, 2021

Conversation

DrLuke
Copy link
Contributor

@DrLuke DrLuke commented Sep 23, 2021

Document a solution for using passwords that start with a dash. This happened to a few people when using automatically generated tokens in a CI environment.

Resolves: #2889

Document a solution for using passwords that start with a dash. This happened to a few people when using automatically generated tokens in a CI environment.
See: python-poetry#2889
jeremad
jeremad previously approved these changes Sep 28, 2021
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line wrapping is a little odd here -- fix that to match the surrounding text and this LGTM.

@DrLuke
Copy link
Contributor Author

DrLuke commented Nov 14, 2021

The line wrapping is a little odd here -- fix that to match the surrounding text and this LGTM.

Where exactly? It looks fine in github's markdown renderer, and I couldn't figure out how to build the documentation website myself so I don't know how to check that 😅

@neersighted
Copy link
Member

The line wrapping is a little odd here -- fix that to match the surrounding text and this LGTM.

Where exactly? It looks fine in github's markdown renderer, and I couldn't figure out how to build the documentation website myself so I don't know how to check that 😅

In the markdown itself -- the literal newlines in the source file. Sorry, should have been more clear that I meant the source form vs the rendered form.

@DrLuke
Copy link
Contributor Author

DrLuke commented Nov 14, 2021

The line wrapping is a little odd here -- fix that to match the surrounding text and this LGTM.

Where exactly? It looks fine in github's markdown renderer, and I couldn't figure out how to build the documentation website myself so I don't know how to check that sweat_smile

In the markdown itself -- the literal newlines in the source file. Sorry, should have been more clear that I meant the source form vs the rendered form.

No worries! Like this? Sorry if I'm totally missing what you're saying 😅

docs/repositories.md Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@neersighted neersighted merged commit 2f4841d into python-poetry:master Nov 14, 2021
1nF0rmed pushed a commit to 1nF0rmed/poetry that referenced this pull request Nov 15, 2021
…ython-poetry#4552)

Document a solution for using passwords that start with a dash. This happened to a few people when using automatically generated tokens in a CI environment.

Fixes python-poetry#2889

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
edvardm pushed a commit to edvardm/poetry that referenced this pull request Nov 24, 2021
…ython-poetry#4552)

Document a solution for using passwords that start with a dash. This happened to a few people when using automatically generated tokens in a CI environment.

Fixes python-poetry#2889

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@lovetheguitar
Copy link

@DrLuke Thanks for the docs update, I ran into this issue explicitly, but the docs do not appear to include your changes on the website? At least I could not find the relevant entry here: https://python-poetry.org/docs/repositories/#configuring-credentials

Thanks. 😃

@DrLuke DrLuke deleted the patch-1 branch May 3, 2022 19:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http basic config password starting with "-"
4 participants