Fix for "poetry lock --no-update" so that dependencies with extras are not updated unnecessarily #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neersighted: Shall I rebase the branch so that the FreeBSD test can succeed or should I wait for your review? |
Please go ahead and rebase! There are enough changes in master that even non-significantly stale PRs will need to be rebased to have confidence in testing anyway. Thanks! |
radoering
force-pushed
the
fix-lock-no-update-for-deps-with-extras
branch
3 times, most recently
from
764a964
to
8b5b090
Compare
neersighted
requested changes
Nov 21, 2021
…e not updated unnecessarily
…ing version is found)
radoering
force-pushed
the
fix-lock-no-update-for-deps-with-extras
branch
from
e742a8f
to
2234ceb
Compare
3 tasks
neersighted
approved these changes
Mar 8, 2022
Merged
3 tasks
3 tasks
3 tasks
Closed
2 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4612
Resolves: #3128
Resolves: #5185
When calling
poetry lockwith--no-updatedependencies with extras should not be updated unnecessarily.