Handle NotImplementedError when creating symlink on install; fixes #4626 #4630
Conversation
|
I don't know if the poetry CI is already taking too much time, but you could add runs for python3.10 and pypy3.7 by changing poetry/.github/workflows/main.yml Line 26 in 82459bd to (note the quotes to force a string, not a number, critical for 3.10) |
Thanks for the suggestion. The CI is just waiting for a maintainer to kick it off since I have not contributed to this codebase before. Also, since this change is focused on pypy, I will omit 3.10 from the update. |
|
The failed test is actually what the PR is fixing. The bootstrap uses the code from the project's default branch, this should pass once merged. https://github.com/python-poetry/poetry/runs/4038721220?check_suite_focus=true#step:5:34 |
There was a problem hiding this comment.
Looks like the CI runs are failing for OSX + pypy. Will need to fix those before we can merge this.
Ref: https://github.com/python-poetry/poetry/runs/4038720998?check_suite_focus=true
Might also be good to split out the install script changes and the github action changes into separate commits. Something like:
installer: handle NotImplementedError on symlink
Resolves: #4626
ci: add pypy to test matrix
|
I'm not sure why the FreeBSD checks are failing installing tox. Could it be due to the pinning of the PyPi version? It looks unrelated to me. |
|
@havocbane try rebasing the branch, #4668 should remove tox usage. |
Thanks! The FreeBSD checks are passing now. |
|
@havocbane can you resolve the install-poetry conflicts please? |
| @@ -322,8 +322,11 @@ def _get_release_info(self, name: str, version: str) -> dict: | |||
| return data.asdict() | |||
|
|
|||
| def _get(self, endpoint: str) -> Union[dict, None]: | |||
| headers = { | |||
There was a problem hiding this comment.
Looks like some unrelated changes came along for the ride. Could we back these out, and open a separate PR with tests if they are necessary?
There was a problem hiding this comment.
Ah, good catch. I was trying to debug the mac failures from the CI. I'll back these out in a new pull request.
|
Given the extra changes that came along, and the fact that the installer script has been factored out, I am going to close this in favor of a PR at https://github.com/python-poetry/install.python-poetry.org. For anyone using the old URL, they will not get the improved version of this script after merge. However, I would prefer an issue on that repo to discuss if we'll keep the version in the main poetry repository in sync, or something else. |
|
I encountered the same issue with being unable to install |
@hoefling Unfortunately, life kind of got in the way and I didn't keep up with the changes here. If this is still an issue, I can make a change over there. I know a lot of time has passed since this came up, so sorry for that. |
What version of pypy3? The latest pypy7.3.13 added support for symlinks in windows, so it should work now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Handle
NotImplementedErrorwhen creating symlink on install. I was able to recreate the issue locally with PyPy version 3.7.10 and Poetry version 1.1.11 and I verified my fix after making changes:python install-poetry.pycompleted successfully with this change in place. If accepted, please tag the merge with the label hacktoberfest-accepted.Resolves: #4626
I am happy to add a test over this change if requested, but I don't see where tests covering the
install-poetry.pyscript live in the repository.