Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize installation paths on Windows #4651

Closed
wants to merge 1 commit into from
Closed

Sanitize installation paths on Windows #4651

wants to merge 1 commit into from

Conversation

f0ff886f
Copy link

Pull Request Check List

Resolves: #4163

  • Added tests for changed code.
  • Updated documentation for changed code.

I'm starting a PR for 4163 as it hits many Windows users and results in a broken poetry. I'm reusing fixes from the issue and would be happy to fix up the PR with tests if someone could point how to properly test this behaviour on Windows.

@f0ff886f
Copy link
Author

The failed tests seem to have failed for environment reasons (ConnectionResetByPeer), not sure how to rerun them. https://cirrus-ci.com/task/5416883047366656

@f0ff886f
Copy link
Author

Closing this because its a poor dupe of #4549 and #4531.

@f0ff886f f0ff886f closed this Oct 18, 2021
@f0ff886f f0ff886f deleted the patch-1 branch October 18, 2021 14:51
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError, whl in cache does not exist when running poetry install again
1 participant