Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvement for issue #4844 #4847

Merged
merged 4 commits into from
May 17, 2022
Merged

Documentation improvement for issue #4844 #4847

merged 4 commits into from
May 17, 2022

Conversation

ttamg
Copy link
Contributor

@ttamg ttamg commented Nov 29, 2021

Resolves: #4844

Small docs fix that adds a warning box to suggest using quotes on some shells such as Mac Zsh.

  • Added tests for changed code. NO CHANGED CODE - ONLY DOCS IN PR
  • Updated documentation for changed code.

@ttamg ttamg mentioned this pull request Nov 29, 2021
Closed
neersighted
neersighted requested changes Nov 29, 2021
View reviewed changes
docs/cli.md Outdated Show resolved Hide resolved
ttamg and others added 2 commits November 29, 2021 16:20
@ttamg @neersighted
Update docs/cli.md
bc160e3 
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@ttamg
Added quotes to line 339
6597e16
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neersighted
Copy link
Member

neersighted commented Nov 29, 2021 •
edited
Loading

This PR was based off of a stale master and doesn't have the correct workflows. Can you please rebase on top of current master to get this merged?

(Also, please use feature branches in the future. If you created this PR off a branch and not your own master, a maintainer could have corrected the stale base for you.)

@ttamg
Copy link
Contributor Author

ttamg commented Nov 30, 2021

@neersighted I believe I have done that now. Next time would do on a separate branch as you suggest. Hope this is now rebased correctly. If not then please let me know what I missed! Thanks

@Secrus Secrus requested a review from neersighted May 16, 2022 23:51
@neersighted neersighted reopened this May 17, 2022
@neersighted neersighted merged commit 02dbe01 into python-poetry:master May 17, 2022
@abn abn mentioned this pull request Jun 6, 2022
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted Awaiting requested review from neersighted

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation fix - poetry add with square brackets requires quotes
2 participants
@ttamg @neersighted