Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pyproject readme docs #5158

Conversation

patrick-ryan
Copy link
Contributor

Pull Request Check List

Resolves: #5069

  • Added tests for changed code.
  • Updated documentation for changed code.

I rendered the file in vscode, but let me know if there's a way to generate + host the docs locally so I can preview, thanks!

@abn abn added the area/docs Documentation issues/improvements label May 13, 2022
@github-actions
Copy link

github-actions bot commented May 13, 2022

Deploy preview for website ready!

✅ Preview
https://website-m7ugtzjqf-python-poetry.vercel.app

Built with commit 54da53e.
This pull request is being automatically deployed with vercel-action

```toml
[tool.poetry]
# ...
readme = "./README.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need ./ prefix. It is unnecessary, as it points to the same directory and can be confusing.

Copy link
Contributor Author

@patrick-ryan patrick-ryan May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay np I fixed that, looks better now. thanks for the review!

Secrus
Secrus previously approved these changes May 17, 2022
@Secrus Secrus requested a review from a team May 17, 2022 07:36
@neersighted
Copy link
Member

I will have to double check, but I think this might be outdated as we've landed support for multiple README files that get combined.

@neersighted
Copy link
Member

Yeah, we've added support for readme being a list:

https://github.com/python-poetry/poetry-core/blob/b7c99733539aa443313c0d08fd4b85f8e5230bfc/src/poetry/core/factory.py#L146

A quick touchup to reflect that would be appreciated!

@Secrus Secrus added the status/waiting-on-response Waiting on response from author label May 22, 2022
@Secrus
Copy link
Member

Secrus commented Jun 1, 2022

@patrick-ryan are you still up for completing this?

@patrick-ryan
Copy link
Contributor Author

yep I'll take a look at this, thanks for the ping

@patrick-ryan
Copy link
Contributor Author

okay updated to include the option of specifying a list of readme paths, let me know if that looks okay

Secrus
Secrus previously requested changes Jun 1, 2022
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
patrick-ryan and others added 6 commits June 1, 2022 21:34
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
…k-ryan/poetry into 5069-pyproject-readme-docs-update
docs/pyproject.md Outdated Show resolved Hide resolved
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I see you've committed most of my suggestions -- the line wrapping will be broken -- could you please reflow these paragraphs to be 80 columns wide?

@neersighted neersighted merged commit 5c60dac into python-poetry:master Jun 2, 2022
@abn abn mentioned this pull request Jun 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements status/waiting-on-response Waiting on response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document how to set long_description
4 participants