Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually sure how to make a test for this, but in debugging some other issues I found that urllib3 needs to be at least version 1.26.0 to use the
allowed_methods
parameter on the Retry class:poetry/src/poetry/publishing/uploader.py
Line 73 in 7cc6849
Or, it needs to continue using
method_whitelist
which is deprecated but not going to be removed until urllib3 v2.0... That would probably be safer in terms of restricting the downstream dependencies? Curious what you think. But maybe the restriction is ok considering people aren't screaming aboutpoetry publish
failing...This is where I first saw it.
Probably introduced in #4580.