Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factory: reuse dependency specification utils #5558

Merged
merged 1 commit into from
May 7, 2022
Merged

factory: reuse dependency specification utils #5558

merged 1 commit into from
May 7, 2022

Conversation

abn
Copy link
Member

@abn abn commented May 7, 2022

No description provided.

@abn abn requested a review from neersighted May 7, 2022 16:26
@abn
Copy link
Member Author

abn commented May 7, 2022 •
edited
Loading

@neersighted since you reviewed #5554 can I get your eyes here too?

neersighted
neersighted approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my complaints are minor typing ones -- and mostly about readability. They can always be revisited later, and in no way affect the code quality which is good :)

@neersighted neersighted merged commit bb30530 into python-poetry:master May 7, 2022
@abn abn deleted the factory-reuse-spec-utils branch May 7, 2022 17:08
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abn @neersighted