new command to support more options #5710

juhoautio · 2022-05-27T23:29:28Z

Adding all the missing options that are asked interactively by the init command.

Also improving & fixing the doc of init command to match.

Question: How to validate the rendering of docs/cli.md (especially the relref)?
-> Answered in #5708 (comment)

Question: Is it on purpose that mypy is not part of the pre-commit hooks? My 1st push failed on CI because of a mypy error because I didn't realize I should've ran it manually.
-> Answered in #5710 (comment)

Pull Request Check List

Resolves: #1854

Added tests for changed code.
Updated documentation for changed code.

Adding all the missing options that are asked interactively by the init command

github-actions · 2022-05-28T11:18:59Z

Deploy preview for website ready!

✅ Preview
https://website-67l9ix9lp-python-poetry.vercel.app

Built with commit 16caa17.
This pull request is being automatically deployed with vercel-action

neersighted · 2022-06-04T04:42:36Z

Question: Is it on purpose that mypy is not part of the pre-commit hooks? My 1st push failed on CI because of a mypy error because I didn't realize I should've ran it manually.

Yes, it is for now. mypy was part of our pre-commit hooks but we can't run it in the correct environment without duplicating our list of dependencies. We are probably going to set it up as a tox environment and then suggest running tox to trigger pytest and mypy.

neersighted

I'm not very enthusiastic about subclassing the init command -- instead, I would prefer to see the common parts of both commands factored out into shared helpers. Also, let's drop the -l short option for --license as it's inconsistent and it was never documented.

juhoautio · 2022-06-04T06:34:46Z

There are some existing commands that inherit the InitCommand. Should those be also detached by extracting shared helpers? Maybe not yet in this PR though.

juhoautio · 2022-06-07T21:52:30Z

Also, let's drop the -l short option for --license as it's inconsistent and it was never documented.

Added in commit 7d578a1.

I would prefer to see the common parts of both commands factored out into shared helpers.

Done in commit a09c47b.

juhoautio · 2022-06-10T20:20:15Z

@neersighted is this ok? or something to improve still?

juhoautio · 2022-09-01T18:28:42Z

@neersighted I tried to address the review comments but looks like this PR was forgotten and there are some conflicts to be resolved. Those should be easy to fix, but would it be possible to have a review for the commits that I added since you last checked this?

neersighted · 2022-09-11T19:33:41Z

Hi @juhoautio -- the maintainers are busy people doing this in their spare time. While an occasional ping (especially to those who have already interacted with a PR/issue) is not unwelcome, pinging people who have not expressed interest in an issue or reviewing code, without a prior understanding of what they are interested in helping with, is generally considered rude. Likewise, pinging repeatedly is generally considered rude.

Additionally, Github as a 'request review/re-review' feature that is generally used for this and makes it easier to reason about what reviews are left on your to-do list as a contributor with many priorities.

Most reviewers will not take a look at code that is conflicted and failing tests as non-mergable code must, by its nature, change (often substantially) in order to be accepted. Thus reviewing it is generally a waste of time for all parties involved. I am sorry that I did not comment that here -- hopefully that explanation/expectation helps in the future when you request reviews.

juhoautio · 2022-09-12T18:39:06Z

Sorry! I had not noticed that there's a Re-request review feature, or at least didn't remember. I'll use that from now on.

I'm also very sorry that I ended up using desperate means like pinging another maintainer. In fact I wasn't sure how to best raise my question about what I should be doing next without appearing rude, yet I failed at it. In the end, I now have the guidance that I was looking for. Thanks a lot for that.

neersighted

Overall looks good to me, but I'm not sure about the addition of --dev-dependency while we're moving away from --dev. I think we should either generalize it to any group, or just drop it in general as it's going to be pretty niche during new.

juhoautio · 2022-09-18T08:47:23Z

Should the existing --dev-dependency option of init be deprecated?

How about having a new option --group-dependency for both init and new? The value format could be GROUP:DEPENDENCY.

e.g. dev:requests:^2.10.0 or dev:requests=2.11.1 or dev:requests.

or just drop it in general as it's going to be pretty niche during new

The ability to set dev dependencies with new is needed for my use case. Or then I would like to have an option for add that allows only modifying pyproject.toml without updating poetry.lock.

neersighted · 2022-09-18T18:21:05Z

I think the best move is to drop the --dev-dependency change from this PR, and then introduce a new PR deprecating --dev-dependency on init and adding --group-dependency using the design you've proposed.

neersighted

Some more tweaks -- there is a lot of moving code around in this PR in the same commit it was changed, so it's a bit hard to review.

I think we should block this on #6669 as the new AbstractRepository introduced in that PR will make all the functions that currently take Pool (which just has PyPiRepository in it anyway) much cleaner and allow for dropping Pool until such time that we actually support searching sources other than PyPI.

neersighted · 2022-10-10T07:04:15Z

src/poetry/console/commands/new.py

@@ -88,3 +134,12 @@ def handle(self) -> int:
        )

        return 0
+
+    def _get_pool(self) -> Pool:
+        if isinstance(self, EnvCommand):


This check makes no sense given the type of the command.

neersighted · 2022-10-10T07:05:22Z

src/poetry/utils/requirements.py

+    return result
+
+
+def create_pool() -> Pool:


Let's drop this helper and keep things inline -- it's less messy than stashing this helper in such an obscure place, and this isn't the PR to solve the ergonomics of creating the pool in anyway. If you want to clean things up and be a bit more specific, you can just use PyPiRepository.search() instead of creating a pool with one repository.

If you want to clean things up and be a bit more specific, you can just use PyPiRepository.search() instead of creating a pool with one repository.

I'm all for cleaning things up, but not sure what it means to replace this with PyPiRepository.search() -> moving the code inline. Also, good to avoid additional refactoring in this PR's scope.

juhoautio · 2022-10-10T19:57:56Z

there is a lot of moving code around in this PR in the same commit it was changed, so it's a bit hard to review.

This is unfortunate, yes. The commit to blame for most of the refactoring is a09c47b. In that commit I am only moving the existing code to functions but not changing it otherwise.

I think we should block this on #6669 as the new AbstractRepository introduced in that PR will make all the functions that currently take Pool (which just has PyPiRepository in it anyway) much cleaner and allow for dropping Pool until such time that we actually support searching sources other than PyPI.

Looks like that PR was already merged 🎉 I'm sorry but I couldn't figure out what it would mean in practice for this PR, how to replace Pool with AbstractRepository in these functions? I was about to take AbstractRepository in find_best_version_for_package but it ends up using VersionSelector(pool). Is it possible to change the signature of VersionSelector to take AbstractRepository instead of Pool?

I committed something along these lines, curious to hear the feedback (commit b3e5364). But I rolled it back because it seemed to be trying real PyPI calls and made the build fail on Travis. I would also like to omit it to keep this PR simpler.

juhoautio · 2022-10-10T20:17:07Z

src/poetry/console/commands/show.py

@@ -528,7 +528,7 @@ def find_latest_package(
                    return provider.search_for_direct_origin_dependency(dep)

        name = package.name
-        selector = VersionSelector(self.poetry.pool)
+        selector = VersionSelector(self.poetry.pool.repositories[0])


What would be the right way to handle this? Moving from Pool to AbstractRepository.

This reverts commit b3e5364.

finswimmer · 2022-10-21T11:28:12Z

@juhoautio: Sorry I'm late to the party. I think we should rework the implementation of poetry new and poetry init in that way, that poetry new becomes an extended version of poetry init. Doing this we can makes sure, that new have at least the same options as init, even if we introduce a new option.

This is why I closed the issue you've linked in your PR description. The new "major" ticket should be #2563 now.

juhoautio · 2022-10-22T06:57:08Z

@finswimmer is someone (you?) going to work on implementing #2563 some time soon? If yes, does that means this PR is rejected after all? But if no one will work on #2563, I would still hope to have this PR merged with the current scope ie. just adding some missing options & fixing some docs without any bigger refactoring.

finswimmer · 2022-10-22T07:10:05Z

Hey @juhoautio ,

this doesn't mean your PR is rejected. The scope is not that far away from #2563 and I was hoping that you maybe like to go that extra mile. :)

fin swimmer

juhoautio · 2022-10-22T09:33:27Z

I could work on it if you'd like, but if the design changes that much, I think starting from a clean slate with a new PR could be better. I would hope to have some guidance on the desired approach for implementing it. Please let me know.

I'm still wondering if this PR could be finished because it's almost there. Maybe I'm also missing what additional use cases the new alternative will enable compared to this.

Secrus · 2024-03-03T00:47:30Z

Superseded by #9088

github-actions · 2024-04-03T00:22:35Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

new command to support more options

f5e625c

Adding all the missing options that are asked interactively by the init command

Secrus added the area/docs Documentation issues/improvements label May 28, 2022

juhoautio added 6 commits May 31, 2022 01:07

Fix mypy error

e4e036d

Fix the new test

5e82630

Docs: add a missing bracket

73c0cfb

Docs: add a missing bracket

cd0bee9

Docs: add a missing colon

125e301

Try to fix the test on Windows

f4a190a

neersighted requested changes Jun 4, 2022

View reviewed changes

juhoautio added 2 commits June 7, 2022 23:42

Drop -l as a short version of --license

7d578a1

Extract helpers.requirements, don't inherit InitCommand

a09c47b

Merge branch 'master' into new_command_args

16caa17

juhoautio mentioned this pull request Sep 11, 2022

poetry new to support --dependency & --dev-dependency #1854

Closed

2 tasks

Merge branch 'master' into new_command_args

03e272c

This comment was marked as outdated.

Sign in to view

juhoautio requested a review from neersighted September 12, 2022 18:39

juhoautio added 2 commits September 12, 2022 22:16

Merge branch 'master' into new_command_args

16d52ee

Extract function: create_pool

efb1336

neersighted requested changes Sep 18, 2022

View reviewed changes

juhoautio requested a review from neersighted September 18, 2022 08:47

juhoautio added 3 commits September 24, 2022 10:40

Drop --dev-dependencies from new

ad7e353

Merge branch 'master' into new_command_args

d2a1baf

Merge branch 'master' into new_command_args

e5a6ea9

neersighted requested changes Oct 10, 2022

View reviewed changes

juhoautio added 2 commits October 10, 2022 22:42

Merge branch 'master' into new_command_args

c456461

Move pool creation inline

865c652

juhoautio added 2 commits October 10, 2022 23:15

Pool -> AbstractRepository

b3e5364

Merge branch 'master' into new_command_args

b5ccc78

juhoautio commented Oct 10, 2022

View reviewed changes

juhoautio requested a review from neersighted October 10, 2022 20:17

juhoautio added 2 commits October 10, 2022 23:52

Revert "Pool -> AbstractRepository"

4341009

This reverts commit b3e5364.

Merge branch 'master' into new_command_args

b9ba428

juhoautio force-pushed the new_command_args branch from e387994 to b9ba428 Compare October 11, 2022 21:21

Merge branch 'master' into new_command_args

f3b66b3

Secrus mentioned this pull request Mar 2, 2024

cli/new: support interactive config #9088

Merged

Secrus closed this Mar 3, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new command to support more options #5710

new command to support more options #5710

juhoautio commented May 27, 2022 •

edited

Loading

github-actions bot commented May 28, 2022 •

edited

Loading

neersighted commented Jun 4, 2022

neersighted left a comment

juhoautio commented Jun 4, 2022

juhoautio commented Jun 7, 2022

juhoautio commented Jun 10, 2022

juhoautio commented Sep 1, 2022

neersighted commented Sep 11, 2022

juhoautio commented Sep 12, 2022

This comment was marked as outdated.

neersighted left a comment

juhoautio commented Sep 18, 2022

neersighted commented Sep 18, 2022

neersighted left a comment

neersighted Oct 10, 2022

neersighted Oct 10, 2022

juhoautio Oct 10, 2022

juhoautio commented Oct 10, 2022 •

edited

Loading

juhoautio Oct 10, 2022

finswimmer commented Oct 21, 2022

juhoautio commented Oct 22, 2022

finswimmer commented Oct 22, 2022

juhoautio commented Oct 22, 2022

Secrus commented Mar 3, 2024

github-actions bot commented Apr 3, 2024

new command to support more options #5710

new command to support more options #5710

Conversation

juhoautio commented May 27, 2022 • edited Loading

Pull Request Check List

github-actions bot commented May 28, 2022 • edited Loading

neersighted commented Jun 4, 2022

neersighted left a comment

Choose a reason for hiding this comment

juhoautio commented Jun 4, 2022

juhoautio commented Jun 7, 2022

juhoautio commented Jun 10, 2022

juhoautio commented Sep 1, 2022

neersighted commented Sep 11, 2022

juhoautio commented Sep 12, 2022

This comment was marked as outdated.

neersighted left a comment

Choose a reason for hiding this comment

juhoautio commented Sep 18, 2022

neersighted commented Sep 18, 2022

neersighted left a comment

Choose a reason for hiding this comment

neersighted Oct 10, 2022

Choose a reason for hiding this comment

neersighted Oct 10, 2022

Choose a reason for hiding this comment

juhoautio Oct 10, 2022

Choose a reason for hiding this comment

juhoautio commented Oct 10, 2022 • edited Loading

juhoautio Oct 10, 2022

Choose a reason for hiding this comment

finswimmer commented Oct 21, 2022

juhoautio commented Oct 22, 2022

finswimmer commented Oct 22, 2022

juhoautio commented Oct 22, 2022

Secrus commented Mar 3, 2024

github-actions bot commented Apr 3, 2024

juhoautio commented May 27, 2022 •

edited

Loading

github-actions bot commented May 28, 2022 •

edited

Loading

juhoautio commented Oct 10, 2022 •

edited

Loading