Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small poetry init fixes #5946

Merged

Conversation

wieczorek1990
Copy link

  • Fixed invalid authors field population
  • Fixed no info about skipping while adding packages

@dimbleby
Copy link
Contributor

dimbleby commented Jul 3, 2022

Edited because I misunderstood. Conceptually you are removing surrounding single quotes rather than apostrophes (admittedly they look the same!)

I don't see any surrounding single quotes in names generated from VCS config. What is your setup that does give them?

@wieczorek1990
Copy link
Author

wieczorek1990 commented Jul 3, 2022 via email

@wieczorek1990
Copy link
Author

I had bad data inputed in .gitconfig with single quotation marks.
The problem is not existent.
Now the patch only fixes messages in poetry init to add info about skipping.

Copy link
Member

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkniewallner mkniewallner merged commit bf81d09 into python-poetry:master Jul 3, 2022
@mkniewallner mkniewallner mentioned this pull request Jul 12, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants