Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disambiguate direct-origin dependencies in show-outdated #6016

Merged

Conversation

dimbleby
Copy link
Contributor

if you have, say:

[tool.poetry.dependencies]
poetry = "^1.2.0b3"

[tool.poetry.dev-dependencies]
poetry = {git = "https://github.com/python-poetry/poetry.git"}

and go poetry show --outdated then you hit the runtime error Unknown direct dependency type None.

The reason is that poetry appears twice, once as a direct dependency and once not. And we happen to search for the direct dependency using the one that isn't, if you see what I mean.

This MR also improves the error message by saying which package is the problematic one.

@dimbleby dimbleby changed the title disambiguate direct-origin dependencies in show-oudated disambiguate direct-origin dependencies in show-outdated Jul 14, 2022
Copy link
Member

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a way to reproduce the problem, should we add a non-regression test?

@dimbleby
Copy link
Contributor Author

sure, go for it

@neersighted neersighted merged commit 5ad517c into python-poetry:master Aug 28, 2022
@dimbleby dimbleby deleted the show-outdated-with-repeats branch August 29, 2022 12:48
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants