-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove deprecated CLI options #6210
Merged
finswimmer
merged 2 commits into
python-poetry:master
from
finswimmer:chore/remove-depractions
Aug 22, 2022
Merged
feat!: remove deprecated CLI options #6210
finswimmer
merged 2 commits into
python-poetry:master
from
finswimmer:chore/remove-depractions
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
previously approved these changes
Aug 22, 2022
mkniewallner
approved these changes
Aug 22, 2022
mkniewallner
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should also remove mentions of --default
from the documentation in those places:
finswimmer
force-pushed
the
chore/remove-depractions
branch
from
August 22, 2022 17:33
e6e6eec
to
623f5e3
Compare
Excellent catch @mkniewallner 👍 |
Secrus
reviewed
Aug 22, 2022
mkniewallner
approved these changes
Aug 22, 2022
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CLI options that were introduced during development of Poetry 1.2 but get replaced until today:
poetry plugin
--> usepoetry self add
instead--default
option for group commands --> use--with main
instead