Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip configure env for SelfCommand #6225

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

finswimmer
Copy link
Member

At the moment a venv is created on running a poetry self command. Even if it is not used in the command itself it's unnecessary and lead to problems as reported in #6222. This PR fixes this.

Resolves: #6222

@Secrus Secrus merged commit a490386 into python-poetry:master Aug 24, 2022
@dimbleby
Copy link
Contributor

dimbleby commented Aug 24, 2022

Shouldn't the SelfCommand instead be made not an EnvCommand?

Or perhaps the whole notion of EnvCommand wants abandoning and commands should instead get a requires_venv(self) -> bool or similar.

@finswimmer
Copy link
Member Author

Shouldn't the SelfCommand instead be made not an EnvCommand?

SelfCommand and its derived classes for the several self commands inherit EnvCommand to mirror the functionality from the command without self.

Or perhaps the whole notion of EnvCommand wants abandoning and commands should instead get a requires_venv(self) -> bool or similar.

Yes, I had something similar in mind some time ago. But this would require a bigger refactoring. Let's do it at a later point.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.2.0rc1 - poetry env - Current Python version conflict with pre-existing virtualenv
3 participants