Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locker): poetry lock works if an invalid/incompatible lock file exists #6753

Merged

Conversation

radoering
Copy link
Member

@radoering radoering commented Oct 9, 2022

After having created a lock file 2.0, running poetry lock with poetry 1.2.1 results in the following output:

The lock file is not compatible with the current version of Poetry.
Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command.

Ironically, the error message proposes to run poetry lock which results in this error message.

Further, it doesn't make sense that poetry lock fails because it creates a new lock file from scratch (in contrast to poetry lock --no-update).

Update: Running poetry lock is now also possible if there is a broken lock file.

Resolves: #1196

@radoering radoering added impact/backport Requires backport to stable branch backport/1.2 area/deps Related to representing and locking dependencies labels Oct 9, 2022
@neersighted
Copy link
Member

Does this resolve #1196, or can it be extended to do so?

@radoering radoering force-pushed the lock-with-incompatible-lock-file branch from d6132e0 to 46e2047 Compare October 9, 2022 18:05
@radoering
Copy link
Member Author

It does. I added a test.

@neersighted neersighted added area/error-handling Bad error messages/insufficient error handling area/ux Features and improvements related to the user experience labels Oct 10, 2022
@radoering radoering force-pushed the lock-with-incompatible-lock-file branch from 46e2047 to a83b5e8 Compare October 10, 2022 14:28
@radoering radoering requested a review from a team October 10, 2022 14:32
@neersighted neersighted changed the title locker: enable poetry lock if an incompatible lock file exists feat(locker): poetry lock works if an invalid/incompatible lock file exists Oct 10, 2022
@neersighted neersighted merged commit 7d414af into python-poetry:master Oct 10, 2022
@neersighted neersighted added this to the 1.3 milestone Oct 10, 2022
poetry-bot bot pushed a commit that referenced this pull request Oct 10, 2022
…e exists (#6753)

After having created a lock file 2.0, running `poetry lock` with poetry
1.2.1 results in the following output:

```
The lock file is not compatible with the current version of Poetry.
Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command.
```

Ironically, the error message proposes to run `poetry lock` which
results in this error message.

Further, it doesn't make sense that `poetry lock` fails because it
creates a new lock file from scratch (in contrast to `poetry lock
--no-update`).

Running `poetry lock` is now also possible if there is a broken lock file.

Resolves: #1196
(cherry picked from commit 7d414af)
neersighted pushed a commit that referenced this pull request Oct 10, 2022
…e exists (#6753)

After having created a lock file 2.0, running `poetry lock` with poetry
1.2.1 results in the following output:

```
The lock file is not compatible with the current version of Poetry.
Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command.
```

Ironically, the error message proposes to run `poetry lock` which
results in this error message.

Further, it doesn't make sense that `poetry lock` fails because it
creates a new lock file from scratch (in contrast to `poetry lock
--no-update`).

Running `poetry lock` is now also possible if there is a broken lock file.

Resolves: #1196
(cherry picked from commit 7d414af)
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/deps Related to representing and locking dependencies area/error-handling Bad error messages/insufficient error handling area/ux Features and improvements related to the user experience impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry lock should overwrite broken poetry.lock file, not error out.
2 participants