make keyring fallback optional

[felix-ht]

Fixes #1917 - the root cause of this issue seems to be that any request made by poetry tries to get auth information from the keyring even if the config of the PasswordManager has no indication that the requets needs auth in the first place. This is also the reason why any operation that does any kind of requests fails, with the keyring errors.
This was caused by some code that was bypassing the normal keyring opreations, which i removed.

I updated the test so that they still pass using the normal poetry keyring repo. I also made the keyring protected so access to it is discouraged.

Pull Request Check List

Resolves: #issue-number-here

• Added tests for changed code.
• Updated documentation for changed code.

[neersighted]

I'm not sure this approach is good; some indexes rate-limit users based on credentials (e.g. have lower rate limits for unauthenticated users). Always providing credentials, instead of waiting for an error and retrying, seems to be a better behavior as it generates fewer network requests.

[felix-ht]

I'm not sure this approach is good; some indexes rate-limit users based on credentials (e.g. have lower rate limits for unauthenticated users). Always providing credentials, instead of waiting for an error and retrying, seems to be a better behavior as it generates fewer network requests.

This is not what this does. This doesn’t try without credentials as a first shot - instead is properly uses the config to add the credentials only if needed. So no issues with rate limiting.

[felix-ht]

@neersighted now i see - the assumption is that it should use the keyring even if there is no config - in case there just happens to be a suitable config in the normal namespace of the keyring

[felix-ht]

while this certainly makes sense to have, wouldn’t this very specifc feature - legacy support for keyring entries not created by poetry not be the perefect candiate for a config flag?

[felix-ht]

allright i changed this PR so that the fallback is now an option that can be configured. @neersighted would be great if you could take a look.

(I would assume that this would require some more documentation/discussion before this can merged)

[felix-ht]

don't think that this will get merged, so closing the pr

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.