Calculate and store hash for url dependencies

[dunkmann00]

This performs the same hashing process as is done on file dependencies, for url dependencies. This requires python-poetry/poetry-core#535 to work.

I haven't updated the tests yet as I would first like to get feedback from the maintainers.

Pull Request Check List

Resolves: #7122

• Added tests for changed code.
• Updated documentation for changed code.

[dimbleby]

thanks!

I don't think that attaching the hash() method to the url dependency is the right way:

• you don't use self in that method at all, which is a clue that it doesn't particularly belong there
• you haven't achieved any code re-use, this essentially duplicates the hash() method on the file dependency

I would suggest that the method on the file dependency be deprecated or removed, and you replace it with a standalone utility function that just takes a Path and calculates the hash.

Also you could put that utility in poetry proper rather than poetry-core, which will allow you to make the unit tests work without having cross-repository problems to work through

[dunkmann00]

Okay, I moved hash() into utils.helpers and updated any calls to use this new function.

The tests still fail since the lockfile that's generated has the hashes in it and doesn't match the test fixtures. Is there a recommended way to generate the new fixture test files?

[dimbleby]

Is there a recommended way to generate the new fixture test files?

With a grand total of four failures it shouldn't be very tedious just to fix up those testcases manually,

pytest -k <test-name> -vv will give a fairly readable diff to tell you what's changed so that's easy to copy into the test script (if you're happy with it)

[dunkmann00]

Fixed test failures and added in tests for the new get_file_hash() function. The tests are pulled over from what used to be in poetry-core.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.