-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix poetry shell
for zsh if space character in venv path
#7245
Conversation
fix zsh: poetry shell doesn't work if space character in .venv path python-poetry#7244
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even simpler: But the safest one would be: |
Any updates on whether this will get merged in the near future? I am running into the same issue on macOS unfortuantely. |
@PabloEmidio when you have a chance, please check this. |
For what I saw, it should do it. Could any test be added to validate this scenary? |
Not fast because the executing bash script is moked, and I don't have enough expertise in pytest to change that. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
poetry shell doesn't work if space character in .venv path
poetry shell
for zsh if space character in venv path
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fix zsh: poetry shell doesn't work if space character in .venv path
Pull Request Check List
Resolves: #7244
Confirmed working on bash, zsh