Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove exception when keyring is locked #8227

Merged
merged 6 commits into from
Oct 3, 2023
Merged

fix: remove exception when keyring is locked #8227

merged 6 commits into from
Oct 3, 2023

Commits on Oct 3, 2023

  1. fix: remove exception when keyring is locked python-poetry#1917

    @MatthieuBizien @radoering
    MatthieuBizien authored and radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6a1b550 View commit details
    Browse the repository at this point in the history

  2. Catch KeyringError and RuntimeError when accessing keyring. 

    * src/poetry/utils/password_manager.py (PoetryKeyring.get_credential)
    @real-yfprojects @radoering
    real-yfprojects authored and radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b69737f View commit details
    Browse the repository at this point in the history

  3. Test locked keyring 

    * tests/conftest.py : Implement `LockedBackend` inheriting `KeyringBackend` and throwing `KeyringLocked` on access.

* tests\utils\test_authenticator.py : Test that locked keyrings still lead to a request.

* tests\utils\test_password_manager.py : Test that locked keyrings do not fail.
    @real-yfprojects @radoering
    real-yfprojects authored and radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    fc81f0d View commit details
    Browse the repository at this point in the history

  4. WIP erroneous backend tests

    @real-yfprojects @radoering
    real-yfprojects authored and radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6292400 View commit details
    Browse the repository at this point in the history

  5. Test a keyring raising KeyringError on access. 

    * tests/utils/test_authenticator.py
* tests/conftest.py
    @real-yfprojects @radoering
    real-yfprojects authored and radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    5e00b18 View commit details
    Browse the repository at this point in the history

  6. improve tests

    @radoering
    radoering committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    aea0957 View commit details
    Browse the repository at this point in the history