-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix POETRY_REPOSITORIES_ variable docs #8492
Fix POETRY_REPOSITORIES_ variable docs #8492
Conversation
it's not so simple as that: I can believe that there are clarity improvements to be made here and it would be good to see that: but I don't think this MR as it stands helps with that |
What do you suggest? Do you want me to explain that the should match naming in sources? |
the current doc has a heading However your MR leaves that heading alone, so now the doc is not self-consistent. I realise that disentangling this is more than the four character fix you were hoping for! |
Oh, i get it now. |
As I understand it, global repository configuration is only interesting during publishing, so eg priority is irrelevant - I think url is the only interesting property. |
So...? :D |
So: put some or more of that in the docs! |
@dimbleby check if this is better. poetry/tests/utils/test_authenticator.py Line 355 in 47a3a19
|
Can I improve this PR in any way? |
Deploy preview for website ready! ✅ Preview Built with commit 7bb092c. |
POETRY_REPOSITORIES_<NAME>_URL
Includes basic auth updates
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
b261651
to
7bb092c
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
POETRY_REPOSITORIES__URL wrong in the documentation
Pull Request Check List
Resolves: #8491
No changes are required to the code.