Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wheel_file_re RegExp #9770

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Fix wheel_file_re RegExp #9770

merged 9 commits into from
Oct 16, 2024

Conversation

AlekseyLobanov
Copy link
Contributor

@AlekseyLobanov AlekseyLobanov commented Oct 14, 2024 •
edited
Loading

Pull Request Check List

Resolves: #9769

  • Added tests for changed code.
  • Updated documentation for changed code.
  • For performance POC check related issue
  • All interfaces are the same
  • It covers two problems but I believe that they are close enough (few characters in the single RE)

@dimbleby
Copy link
Contributor

I have no idea why the code thinks that dist-info is a valid wheel extension, it probably is just legacy wrongness that should be removed.

If it has never even worked in all these years anyway, that's pretty good evidence that it is safe to remove it.

radoering
radoering previously requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Let's remove the dist-info part.

@AlekseyLobanov
Copy link
Contributor Author

I removed .dist-info extension from RE. No problems with tests.

@Secrus Secrus enabled auto-merge (squash) October 16, 2024 20:09
@Secrus Secrus dismissed radoering’s stale review October 16, 2024 21:02

another core maintainer overwrite

@Secrus Secrus merged commit 80d09c0 into python-poetry:main Oct 16, 2024
87 checks passed
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
@AlekseyLobanov @Secrus
Fix wheel_file_re RegExp (python-poetry#9770)
197d3a1
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Secrus Secrus Secrus approved these changes

@radoering radoering Awaiting requested review from radoering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with wheel_file_re
4 participants
@AlekseyLobanov @dimbleby @Secrus @radoering