feat(cli)!: actually switch directory with --directory/-C

[finswimmer]

Pull Request Check List

--directory now switch the current working folder, so that relative paths are resolved relative to the given folder.

To retain the old behavior the --project flag is introduced.

Resolves: #7897

• Added tests for changed code.
• Updated documentation for changed code.

[github-actions]

Deploy preview for website ready!

✅ Preview
https://website-fby04ghrm-python-poetry.vercel.app

Built with commit e5e553b.
This pull request is being automatically deployed with vercel-action

[radoering]

Can we add some sort of test for the new option?

[finswimmer]

Can we add some sort of test for the new option?

I really would like to add some tests. But until now I wasn't able to do so because I don't know how.

The scenario I have in mind goes like this:

• install a Poetry project with a tool.poetry.scripts entrypoint
• This entrypoint simply prints out the current working directory
• run poetry run from outside the project folder with either --directory or --project and compare the output of the script with the expected

So any help is appreciated 😃

[radoering]

Most similar test is probably

poetry/tests/console/commands/test_run.py

Line 153 in 341071a

def test_run_script_sys_argv0(

which runs a scripts entrypoint and checks the error output.

In https://github.com/python-poetry/poetry/tree/main/tests/fixtures/scripts, there is a project, which already has some entry points. There, you can add another one.

[finswimmer]

Thanks @radoering. 👍 I played around a while, but due to the creation of venv I find it to complicated. In finally choose the version command to demonstrate what should happen when using the parameters.

[Secrus]

What is the expected behaviour when user passes both --project and --directory? I feel like there should be some more info on that matter, it doesn't feel intuitive right now and the docs are quite vague on the difference between those two.

[radoering]

What is the expected behaviour when user passes both --project and --directory?

I did not check, but my expectation is that the working directory is changed but the pyproject.toml is searched in --project.

I feel like there should be some more info on that matter, it doesn't feel intuitive right now and the docs are quite vague on the difference between those two.

I agree it makes sense to add a sentence about this special case. Maybe, we should even add a test case where both parameters are used.

[finswimmer]

I agree it makes sense to add a sentence about this special case. Maybe, we should even add a test case where both parameters are used.

I've added a test case. Any suggestion for extending the docs?

[radoering]

Any suggestion for extending the docs?

Maybe an info box below the global options. However, while thinking about what to write I did not come up with something that is saying more than what has already been added in #9831 (comment). Maybe, that is sufficient.