-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping: Remove traces of python2.7 #3
Conversation
@Poogles thanks for this, however as discussed in Gitter the first release of the new fork will be keeping the Python 2 support. This is just to enable existing users (if there are any) to receive the bugfixes that were meant to be part of the Flask-RESTPlus 0.14.0 release that we were unable to publish due to @noirbizarre's absence. Removal of Python2 will come in the next release of |
@SteadBytes yeah that's fine, I can't see any of this PR going stale anytime soon. |
It might have some fun conflicts after #2 is merged - e shall have to wait and see 😅 |
I'll rebase this after lunch ^^ |
@Poogles I really appreciate your enthusiasm! But there's no rush on this - we're not ready for the first release yet and are yet to plan and prioritise work for the subsequent release (of which this may be part of) 😊 |
As we thought, tons of conflicts post merging #2. We did our first release, so we can put this to the top of the stack again. |
@Poogles It's a good time to continue this work 👍 |
@Poogles we are now ready to move forward with this change. Would you have a chance to continue your work? Thanks |
FYI, I'll continue the work from here. |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage ? 96.49%
=========================================
Files ? 15
Lines ? 2081
Branches ? 0
=========================================
Hits ? 2008
Misses ? 73
Partials ? 0 Continue to review full report at Codecov.
|
closing this PR in favor of #113 |
As above. Might be worth us setting up CI before this gets merged, everything passes locally but that never fills me with confidence...
There's a few places where I've started removing 3.4 support as well (check Tox/setup.py). Can remove these if required but if not I'll add another PR later finishing removing 3.4 support.