Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Remove traces of python2.7 #3

Closed
wants to merge 4 commits into from
Closed

Housekeeping: Remove traces of python2.7 #3

wants to merge 4 commits into from

Conversation

Poogles
Copy link
Contributor

@Poogles Poogles commented Jan 10, 2020

As above. Might be worth us setting up CI before this gets merged, everything passes locally but that never fills me with confidence...

There's a few places where I've started removing 3.4 support as well (check Tox/setup.py). Can remove these if required but if not I'll add another PR later finishing removing 3.4 support.

@SteadBytes
Copy link
Contributor

SteadBytes commented Jan 10, 2020

@Poogles thanks for this, however as discussed in Gitter the first release of the new fork will be keeping the Python 2 support. This is just to enable existing users (if there are any) to receive the bugfixes that were meant to be part of the Flask-RESTPlus 0.14.0 release that we were unable to publish due to @noirbizarre's absence. Removal of Python2 will come in the next release of flask-restx where we make some real progress 😄

@Poogles
Copy link
Contributor Author

Poogles commented Jan 10, 2020

@SteadBytes yeah that's fine, I can't see any of this PR going stale anytime soon.

@SteadBytes
Copy link
Contributor

SteadBytes commented Jan 10, 2020

It might have some fun conflicts after #2 is merged - e shall have to wait and see 😅

@Poogles
Copy link
Contributor Author

Poogles commented Jan 13, 2020

I'll rebase this after lunch ^^

@SteadBytes
Copy link
Contributor

@Poogles I really appreciate your enthusiasm! But there's no rush on this - we're not ready for the first release yet and are yet to plan and prioritise work for the subsequent release (of which this may be part of) 😊

@j5awry
Copy link
Contributor

j5awry commented Jan 27, 2020

As we thought, tons of conflicts post merging #2. We did our first release, so we can put this to the top of the stack again.

@SVilgelm
Copy link
Contributor

@Poogles It's a good time to continue this work 👍

@ziirish
Copy link
Contributor

ziirish commented Feb 26, 2020

@Poogles we are now ready to move forward with this change. Would you have a chance to continue your work?
If you don't have time anymore we can also take it from here, just let us know what you prefer.

Thanks

@ziirish
Copy link
Contributor

ziirish commented Apr 12, 2020

FYI, I'll continue the work from here.
Thanks @Poogles for all you've done so far!

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9232e1a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   96.49%           
=========================================
  Files             ?       15           
  Lines             ?     2081           
  Branches          ?        0           
=========================================
  Hits              ?     2008           
  Misses            ?       73           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9232e1a...98308a9. Read the comment docs.

@ziirish
Copy link
Contributor

ziirish commented Apr 13, 2020

closing this PR in favor of #113

@ziirish ziirish closed this Apr 13, 2020
ziirish added a commit that referenced this pull request Oct 16, 2022
remove python < 3.7 support (based on #3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants