Replace pkg_resources with importlib_resources #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
peter-doggart
approved these changes
Sep 24, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 20 20
Lines 2733 2733
=======================================
Hits 2636 2636
Misses 97 97
☔ View full report in Codecov by Sentry. |
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to support Python 3.12 pkg_resources need to be removed.
According to there migration guide it can be replaced by
importlib_resourceshttps://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-filename