Blacken source code #404
Merged
Blacken source code #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
force-pushed
the
black2
branch
2 times, most recently
from
b95d3e0 to
3ed2e29
Compare
black currently has poor multi-line string treatment for dedent()-ed code. I've ran aneeshusa's 'black' branch psf/black#1879 on ropetest instead, which leaves dedent()-ed lines alone while doing all its other cleanups. However most people likely will be running mainline black which would have mucked the formatting in these files, so I've also added an exclusion rule in pyproject.toml to prevent people from accidentally auto-formatting ropetest again. Until aneeshusa's branch are merged into mainline black, or black has a proper solution for dedent()-ed code, be careful of running black on ropetest.
This prevents black reformatting commit from messing with git blame.
You may need to run the following to configure `git blame` to read the ignore
file.
git config blame.ignoreRevsFile .git-blame-ignore-revs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black currently has poor multi-line string treatment for dedent()-ed code.
I've ran aneeshusa's 'black' branch psf/black#1879
on ropetest instead, which leaves dedent()-ed lines alone while doing
all its other cleanups.
However most people likely will be running mainline black which would
have mucked the formatting in these files, so I've also added an
exclusion rule in pyproject.toml to prevent people from accidentally
auto-formatting ropetest again.
Until aneeshusa's branch are merged into mainline black, or black has a
proper solution for dedent()-ed code, be careful of running black on
ropetest.
It's fine to run mainline black on the main
ropefolder, just not theropetestfolder.Credit to @climbus for bringing this topic up.
Fix #399.