Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vars visitor handles python 3.5 dict syntax #144

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Vars visitor handles python 3.5 dict syntax #144

merged 1 commit into from
Jul 13, 2018

Conversation

bcaller
Copy link
Collaborator

@bcaller bcaller commented Jul 12, 2018

of the type {'a': 1, **x}. The **x will have key None.

Before it would crash.

@bcaller
Vars visitor handles python 3.5 dict syntax
6b3f155 
of the type {'a': 1, **x}. The **x will have key None.

Before it would crash.
@bcaller
Copy link
Collaborator Author

bcaller commented Jul 12, 2018

#13

@KevinHock KevinHock self-requested a review July 13, 2018 01:51
KevinHock
KevinHock approved these changes Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 , thanks for making this!

@KevinHock KevinHock merged commit c7a932f into python-security:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinHock KevinHock KevinHock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaller @KevinHock