Tox, travis and requirements #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Jul 24, 2018
.travis.yml
Outdated
| - coverage run -m tests | ||
| - flake8 . --count --exclude=examples --max-complexity=11 --max-line-length=127 --show-source --statistics | ||
| - coverage report --include=tests/* --fail-under 100 | ||
| - coverage report --include=pyt/* --fail-under 70 |
There was a problem hiding this comment.
We should have somewhere around 90% coverage currently, can you adjust it to whatever it is currently?
There was a problem hiding this comment.
Oh I was misreading the coverage report I think. Because pyt/vulnerabilities/vulnerability_helper.py has coverage of 76%, but overall it's 90%. I'll fix this tomorrow.
| deps = -rrequirements-dev.txt | ||
| deps = | ||
| coverage>=4.0,<4.4 | ||
| mock | ||
| commands = | ||
| coverage erase | ||
| coverage run tests | ||
| coverage report --include=tests/* --fail-under 100 | ||
| coverage report --include=pyt/* --fail-under 91 |
There was a problem hiding this comment.
To keep it aligned with this as well I suppose.
In commit 11bcd2d Remove unused function: valid_date an unused import was left in. With the next commit, tox & travis should fail: F401 'datetime.datetime' imported but unused
Requirements: Requirements files aren't used. Requirements.txt and setup.py had odd requirements that I can't see used anywhere. Requirements-dev.txt had conflicting packages (flake8 wants specific versions of pyflakes and pycodestyle). Tox & travis: Split tox into a test, coverage and lint phase. Run either: tox tox -e py36 tox -e cover tox -e lint Tox and travis will now fail the lint / build on flake8 errors to avoid non-compliant code being merged. (--exit-zero removed) Coverage will fail for now, so let's set it really low in travis for now. McCabe complexity is annoying and dealt with better by codeclimate so I bumped it up from 10 to 11 so it won't fail at the moment.
|
I put the code coverage back to 91%. I'd been reading the output incorrectly. 🚢 |
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
Requirements files aren't used. Requirements.txt and setup.py had odd
requirements that I can't see used anywhere. Requirements-dev.txt had
conflicting packages (flake8 wants specific versions of pyflakes and
pycodestyle).
Tox & travis:
Split tox into a test, coverage and lint phase. Run either:
Tox and travis will now fail the lint / build on flake8 errors to
avoid non-compliant code being merged. (
--exit-zeroremoved)Coverage will fail for now, so let's not put it in the travis build yet.
McCabe complexity is annoying and dealt with better by codeclimate so I
bumped it up from 10 to 11 so it won't fail at the moment.