Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default-changelog): add a separate formatted breaking changes section #1110

Conversation

codejedi365
Copy link
Contributor

@codejedi365 codejedi365 commented Nov 30, 2024

Purpose

Rationale

This is more of a stepping stone to the next phase where we will drop the need to display the entire commit in the changelog. The Breaking change descriptions are one of the items we didn't display normally even though it was parsed.

How did you test?

I updated the git repo changelog generator for the E2E scenarios which means the E2E tests that validate changelogs have the correct breaking change summaries included.

I also updated the release notes and changelog template test cases to separate out the breaking change descriptions into their own section and validate the template provides the accurate result.

How to Verify

  1. Checkout this pr
  2. Reset by 4 commits to remove the fix
  3. Run pytest to see the failures where the commits do not include the breaking change descriptions section as they should
  4. Fast forward merge to the latest commit of this pr
  5. Run pytest again to see it is fixed.

@codejedi365 codejedi365 linked an issue Nov 30, 2024 that may be closed by this pull request
@codejedi365 codejedi365 force-pushed the feat/add-breaking-changes-summary-to-changelog branch 10 times, most recently from 900c1c1 to fcd8bfb Compare November 30, 2024 22:13
@codejedi365 codejedi365 force-pushed the feat/add-breaking-changes-summary-to-changelog branch from fcd8bfb to b0d0deb Compare November 30, 2024 22:20
@codejedi365 codejedi365 merged commit 4fde30e into python-semantic-release:master Nov 30, 2024
12 checks passed
@codejedi365 codejedi365 deleted the feat/add-breaking-changes-summary-to-changelog branch November 30, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate breaking changes from other changelog sections
1 participant