-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix auto field warning for django 3.2 #354
fix auto field warning for django 3.2 #354
Conversation
LGTM but I didn't understand this last bit. Can you explain? |
that's not really to that repository that the logs from our CI/CD flow because of missing migrations |
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 93.76% 93.78% +0.02%
==========================================
Files 33 34 +1
Lines 1106 1110 +4
Branches 63 63
==========================================
+ Hits 1037 1041 +4
Misses 44 44
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@atodorov when are you planning to make a new release tag that it could be a part of so that it could be used. |
I can't push new releases to PyPI so that's for @omab to decide. In any case you can still use the application as-is. If the Django warning is bothering you then you can provide the DEFAULT_AUTO_FIELD setting inside your own code base. |
@atodorov @omab I am already using it but still it's bringing that missing migration error. See that logs below that could only be addressed by only new release tag.
|
Proposed changes
I am fixing some waring while upgrading to django 3.2 that have mentioned below in the Other Information section
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
I am facing the following warning while upgrading the django to 3.2 which take the default variable for
DEFAULT_AUTO_FIELD
refSo in lieu of that I am facing the error in my CI/CD that is