Log HTTPError response text

[dases]

Proposed changes

Logging the response text for an HTTPError greatly improves the developer's ability to figure out what might going wrong with an integration.

Checklist

• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added documentation to https://github.com/python-social-auth/social-docs

[nijel]

Logging just the text response might be confusing, it can also be empty.

Suggested change

	social_logger.error(err.response.text)
	social_logger.error("request failes with %d: %s", err.response.status_code, err.response.text)

[dases]

Yeah, better. Thanks.

[dases]

Seems to be a clash of lint constraints.
pre-commit.ci rewrites as f-string, which then fails check

[nijel]

It should use interpolation done by logging, what was reason for 6c3ea1a?

c0a5074 passed CI checks and could be merged.

[dases]

It should use interpolation done by logging, what was reason for 6c3ea1a?

c0a5074 passed CI checks and could be merged.

You're quite right. It looked wrong and I "corrected" it to interpolate a tuple of values like you would for print or whatever, but I see that's not required in logging calls. 🤦

Reverted to c0a5074

Thanks for feedback!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (326d4b3) to head (c0a5074).
Report is 65 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   77.88%   77.95%   +0.06%     
==========================================
  Files         347      347              
  Lines       10669    10694      +25     
  Branches      504      455      -49     
==========================================
+ Hits         8310     8336      +26     
+ Misses       2200     2198       -2     
- Partials      159      160       +1     

Flag	Coverage Δ
unittests	77.95% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.