Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new backend for EGI Check-in #836

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Oct 4, 2023

Proposed changes

New backend for EGI Check-in, EGI's Identity and Access Management service
Learn more at https://www.egi.eu/service/check-in/

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7f314b5) 77.11% compared to head (f6e1c67) 77.16%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   77.11%   77.16%   +0.04%     
==========================================
  Files         337      339       +2     
  Lines       10262    10318      +56     
  Branches      690      694       +4     
==========================================
+ Hits         7914     7962      +48     
- Misses       2192     2200       +8     
  Partials      156      156              
Flag Coverage Δ
unittests 77.16% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
social_core/tests/backends/test_egi_checkin.py 100.00% <100.00%> (ø)
social_core/backends/egi_checkin.py 74.19% <74.19%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enolfc enolfc marked this pull request as ready for review October 4, 2023 15:15
@enolfc
Copy link
Contributor Author

enolfc commented Oct 6, 2023

Will change the name to make clear this is related to EGI

@nijel nijel merged commit 4cdf890 into python-social-auth:master Oct 17, 2023
@nijel
Copy link
Member

nijel commented Oct 17, 2023

Merged, it would be great if you could also add documentation to https://github.com/python-social-auth/social-docs

@nijel nijel self-assigned this Oct 17, 2023
@enolfc enolfc deleted the egi-check-in branch October 17, 2023 09:05
@bgruening
Copy link

Thanks @enolfc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants