Set async library contextvar for asyncio in py3.6 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
AsyncLibraryNotFoundErroris getting raised for an asyncio task in py3.6.Solution
In sniffio 1.2.0, the context var was not getting set for py3.6.
I fixed the if condition and added it back in to set the current async library contextvar for py3.6.
mwakaba2@9126c63#diff-acce973c41d5df27520af82067e245d6f961d963ea70e214028ce8889b5dc8e8
I also tested this with the latest sniffio commit and the if condition is still needed to prevent the error.
Dependency
This fix is needed to fix Jupyter Server #505
TODO