Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to pytest-trio #15

Merged
merged 3 commits into from
Sep 3, 2020
Merged

switch to pytest-trio #15

merged 3 commits into from
Sep 3, 2020

Conversation

altendky
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #15 into master will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   66.29%   65.45%   -0.84%     
==========================================
  Files           5        4       -1     
  Lines         178      165      -13     
  Branches       28       27       -1     
==========================================
- Hits          118      108      -10     
+ Misses         46       44       -2     
+ Partials       14       13       -1     

@pquentin
Copy link
Member

Thanks for this! However I suspect the test suite isn't passing on master either, we would have to fix that first

@altendky
Copy link
Member Author

Agreed. This was checking to make sure that deprecating trio_test() in python-trio/trio#1698 wouldn't create troublesome changes for at least the repos with this cookiecutter generated conftest.py. I'll try to poke at the CI when I get a chance. Reminds me of another project that had trouble with an old attrs on Travis because Travis already had attrs and pip didn't want to update, depending on order of packages requested on the cli...

@altendky altendky mentioned this pull request Aug 30, 2020
@pquentin pquentin merged commit b7a9f57 into python-trio:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants