Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Trio 0.9.0 #5

Merged
merged 4 commits into from
Jan 8, 2019

Conversation

sorcio
Copy link
Contributor

@sorcio sorcio commented Jan 3, 2019

Turns out very little is required:

  • use trio.BrokenResourceError instead of trio.BrokenStreamError and trio.ClosedStreamError (deprecated in Trio 0.5.0)
  • use trio.open_memory_channel() instead of trio.Queue (deprecated in Trio 0.9.0)
  • require Trio >= 0.9.0

@sorcio sorcio requested a review from smurfix January 3, 2019 16:37
@smurfix
Copy link
Collaborator

smurfix commented Jan 3, 2019

Could you try to do something about the test failures? I'm swamped with work …

@sorcio
Copy link
Contributor Author

sorcio commented Jan 4, 2019

@smurfix sure. I had some trouble running tests locally but I'll see what I can do to bring them in good shape.

@sorcio sorcio force-pushed the trio-deprecation-warnings branch from e6bc49f to 3eece4d Compare January 8, 2019 15:11
@sorcio
Copy link
Contributor Author

sorcio commented Jan 8, 2019

Rebased on master after the merge of #6 so tests are now running and passing. @smurfix would you take another look?

I don't understand why the Travis build doesn't appear here on GitHub 😕. It's here. Is it because of something in this PR? But it seemed alright before the latest commit.

@smurfix smurfix merged commit ecfad75 into python-trio:master Jan 8, 2019
@sorcio sorcio deleted the trio-deprecation-warnings branch January 8, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants