Fix flakiness in test_subprocess::test_basic #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-triogh-1514 introduced a race condition in this test: now if the process runs quickly enough, the returncode might have magically become non-None before we check it. Example failure: https://travis-ci.org/github/python-trio/trio/jobs/690291915 There are other tests that check the 'p.returncode is None' case (e.g. test_auto_update_returncode), so we can just delete this.
Merged
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 108 108
Lines 13358 13357 -1
Branches 1012 1012
==========================================
- Hits 13315 13314 -1
Misses 28 28
Partials 15 15
|
|
...and according to some universal law of irony, github actions appears to have flaked out and decided not to test this PR at all. Maybe opening/closing will help? |
njsmith
added a commit
to njsmith/trio
that referenced
this pull request
May 23, 2020
In python-triogh-1546 I fixed the flakiness due to the returncode changing when the process exits, but I missed that the repr also changes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-1514 introduced a race condition in this test: now if the process
runs quickly enough, the returncode might have magically become
non-None before we check it.
Example failure: https://travis-ci.org/github/python-trio/trio/jobs/690291915
There are other tests that check the 'p.returncode is None' case (e.g.
test_auto_update_returncode), so we can just delete this.