Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In KqueueIOManager, close the force-wakeup fd #1623

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 16, 2020

This small bug was introduced in gh-1551

Fixes gh-1621

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #1623 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         110      110           
  Lines       13859    13860    +1     
  Branches     1062     1062           
=======================================
+ Hits        13817    13818    +1     
  Misses         27       27           
  Partials       15       15           
Impacted Files Coverage Δ
trio/_core/_io_kqueue.py 85.12% <100.00%> (+0.12%) ⬆️

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that fixes the warnings I was seeing on macOS with PYTHONDEVMODE=1. 👍

@pquentin pquentin merged commit d11429e into python-trio:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceWarnings with PYTHONDEVMOVE=1
2 participants