The echo server thread in test_ssl had unnoticed errors #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit - Fixes the problem (by ignoring BrokenPipeError after receiving a close_notify, necessary because of our decision in 8b0a252 to close the socket immediately after sending close_notify). - Changes how we run the server thread so that errors can't pass unnoticed in the future, but will instead propagate back into the main thread.
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 99.06% 99.06% +<.01%
==========================================
Files 63 63
Lines 8407 8424 +17
Branches 606 609 +3
==========================================
+ Hits 8328 8345 +17
Misses 62 62
Partials 17 17
Continue to review full report at Codecov.
|
njsmith
force-pushed
the
fix-ssl-test-threading
branch
from
04b5b90 to
7388a97
Compare
njsmith
force-pushed
the
fix-ssl-test-threading
branch
from
7388a97 to
e976598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
Fixes the problem (by ignoring BrokenPipeError after receiving a
close_notify, necessary because of our decision in 8b0a252 to
close the socket immediately after sending close_notify).
Changes how we run the server thread so that errors can't pass
unnoticed in the future, but will instead propagate back into the
main thread.