Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework packaging to use Poetry instead. #2595

Closed
wants to merge 3 commits into from

Conversation

Fuyukai
Copy link
Member

@Fuyukai Fuyukai commented Mar 5, 2023

This does several things:

  1. Kill setup.py and replace it with a Poetry-based pyproject.toml.
  2. Move the code into the src-layout instead.
  3. Separate the tests out into their own directory and package.

Questions I invisige might be asked:

Q: Why Poetry and not ?
A: I only know Poetry and this is my PR.

Q: Why src layout?
A: It has less shenanigans with PYTHONPATH. Also, it's better to do it now and break history (well, git can see the renames but github, in its infinite usability, cannot?) than do a bunch of work on the project and eventually move it over in the future.

Q: Why separate out tests?
A: I couldn't find an answer to "how to make pytest use conftest for installed package tests" in 5 minutes so I just spent the effort to separate them out instead. Also, it annoys me on some level that every trio download includes a few extra kilobytes of tests for no reason.

TODO:

  • Make sure CI works again (I tried, but CI is CI)
  • Quash dissent

@Fuyukai
Copy link
Member Author

Fuyukai commented Apr 12, 2024

Likely not going to happen, and this PR predates several major organisational changes.

@Fuyukai Fuyukai closed this Apr 12, 2024
@Fuyukai Fuyukai deleted the rip-the-plaster-off branch April 12, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant