Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newsfragment for issue #2611, PR #2826 #2836

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Oct 26, 2023

Issue #2611, PR #2826
Accidentally forgot to add the requested newsfragment.

Not super happy with my sentence construction here, feel free to improve it or suggest changes.

@jakkdl jakkdl requested review from Zac-HD and A5rocks October 26, 2023 13:10
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2836 (a36102b) into master (c9e01f4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2836   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         115      115           
  Lines       17514    17514           
  Branches     3125     3125           
=======================================
  Hits        17368    17368           
  Misses        101      101           
  Partials       45       45           

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the newsfragment is readable and I can't think of any great way to phrase it.

@jakkdl jakkdl merged commit 52b3aea into python-trio:master Oct 26, 2023
29 of 30 checks passed
@jakkdl
Copy link
Member Author

jakkdl commented Oct 26, 2023

Thanks for the quick review! 🚀

@jakkdl jakkdl deleted the no_extra_wrap_newsfragment branch October 26, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants