-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of signal_raise
#3126
Get rid of signal_raise
#3126
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 122 122
Lines 18380 18357 -23
Branches 1222 1221 -1
==========================================
- Hits 18312 18289 -23
Misses 47 47
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell, but wondering, why didn't we just use signal.raise_signal
to begin with? Did a bug get fixed or something?
Looking into it lightly, looks like signal.raise_signal
was added in 3.8, so maybe 3.7 support reasons?
I assume the code was written pre-3.8 |
yep, 2017 - 300a19d good find 👍 |
I noticed
signal.raise_signal
seems to do whatsignal_raise
used to. Let's use that instead.