Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ruff to 0.8.0 #3143

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Bump Ruff to 0.8.0 #3143

merged 1 commit into from
Nov 22, 2024

Conversation

AlexWaygood
Copy link
Contributor

Hi! I just released Ruff 0.8.0. This release removes a few rules that had been deprecated for a few releases, so Ruff 0.8.0 would have started emitting warnings when linting trio due to the fact that you have some of these now-removed rules explicitly ignored in your Ruff config.

This PR gets rid of the removed rules from your Ruff config. There's also some additional changes made here; let me know if any of them are undesirable, and I can revert them:

  • Some changes due to the recoding of the flake8-type-checking rules from TCH to TC
  • Some changes due to the addition of the preview rule unraw-re-pattern
  • Some changes due to the addition of the preview rule redundant-none-literal

@AlexWaygood
Copy link
Contributor Author

AlexWaygood commented Nov 22, 2024

(I'm happy to add a news entry if this needs one!)

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (34e7a2e) to head (82028f1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         122      122           
  Lines       18400    18400           
  Branches     1223     1223           
=======================================
  Hits        18331    18331           
  Misses         47       47           
  Partials       22       22           
Files with missing lines Coverage Δ
src/trio/_dtls.py 97.50% <ø> (ø)
src/trio/_socket.py 100.00% <100.00%> (ø)
src/trio/_subprocess_platform/__init__.py 100.00% <100.00%> (ø)
src/trio/_tests/test_testing_raisesgroup.py 100.00% <100.00%> (ø)
src/trio/_tests/test_threads.py 100.00% <100.00%> (ø)
src/trio/testing/_raises_group.py 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@jakkdl jakkdl added the skip newsfragment Newsfragment is not required label Nov 22, 2024
@A5rocks A5rocks merged commit 532ba5f into python-trio:main Nov 22, 2024
38 of 39 checks passed
@trio-bot
Copy link

trio-bot bot commented Nov 22, 2024

Hey @AlexWaygood, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@AlexWaygood AlexWaygood deleted the update-ruff branch November 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip newsfragment Newsfragment is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants