Renames and deprecations for #68 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and deprecate current_call_soon_thread_and_signal_safe. Still need to update callers and docs, but tests are passing (with tons of deprecation warnings).
This lets us use things like: @deprecated(..., instead=BlockingTrioPortal.run) def current_await_in_trio_thread(): ... and the message about BlockingTrioPortal.run now shows up correctly.
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 99.24% 99.25% +<.01%
==========================================
Files 86 87 +1
Lines 10327 10817 +490
Branches 726 786 +60
==========================================
+ Hits 10249 10736 +487
- Misses 61 63 +2
- Partials 17 18 +1
Continue to review full report at Codecov.
|
njsmith
force-pushed
the
rename-call_soon
branch
from
fa66630
to
d716003
Compare
|
Coverage changes appear to be spurious, due to #326 being merged in between the Linux/Windows builds and the MacOS builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Deprecates:
The new API has more consistent naming is generally less confusing due
to the use of actual objects instead of the unconventional returning
closures thing.