Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure chroot command #155

Conversation

gjkloosterman
Copy link
Contributor

Allow the chroot command to be configured to something other than "chroot".

What do these changes do?

With this change the chroot command used by exec_helpers can be configured at runtime.

The intended use case is to make it possible to replace the default chroot command with an alternative that makes /proc available in the chrooted environment. Go binaries fail to execute properly otherwise.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Allow the chroot command to be configured to something other than "chroot".
@gjkloosterman gjkloosterman force-pushed the allow-to-configure-chroot-command branch from 6b52e97 to 96c30e5 Compare May 31, 2024 10:39
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9316905727

Details

  • 13 of 55 (23.64%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 55.058%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_helpers.py 1 2 50.0%
exec_helpers/_ssh_base.py 1 3 33.33%
exec_helpers/api.py 11 25 44.0%
exec_helpers/async_api/api.py 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
exec_helpers/api.py 1 55.07%
exec_helpers/async_api/api.py 1 0.0%
Totals Coverage Status
Change from base Build 9314535336: -0.7%
Covered Lines: 1075
Relevant Lines: 1961

💛 - Coveralls

@penguinolog penguinolog merged commit aa99ff4 into python-useful-helpers:master Jun 3, 2024
19 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants