-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chroot_exe when used with context manager #156
Merged
penguinolog
merged 3 commits into
python-useful-helpers:master
from
gjkloosterman:use-none-for-chroot
Jun 18, 2024
Merged
Fix chroot_exe when used with context manager #156
penguinolog
merged 3 commits into
python-useful-helpers:master
from
gjkloosterman:use-none-for-chroot
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use None for `chroot_exe` default argument. This allows us to use similar logic as `chroot_path`.
gjkloosterman
force-pushed
the
use-none-for-chroot
branch
from
June 17, 2024 15:10
02c9162
to
2833da3
Compare
Pull Request Test Coverage Report for Build 9550169361Details
💛 - Coveralls |
penguinolog
reviewed
Jun 18, 2024
penguinolog
reviewed
Jun 18, 2024
penguinolog
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but need to adjust formatting for readability
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
Pull Request Test Coverage Report for Build 9561885796Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9561887561Details
💛 - Coveralls |
penguinolog
approved these changes
Jun 18, 2024
penguinolog
merged commit Jun 18, 2024
0b32a78
into
python-useful-helpers:master
19 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use None for
chroot_exe
default argument. This allows us to use similar logic aschroot_path
.What do these changes do?
This makes overriding chroot executable in a context manager work as expected.
Are there changes in behavior for the user?
Related issue number
Checklist