Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chroot_exe when used with context manager #156

Merged

Conversation

gjkloosterman
Copy link
Contributor

Use None for chroot_exe default argument. This allows us to use similar logic as chroot_path.

What do these changes do?

This makes overriding chroot executable in a context manager work as expected.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Use None for `chroot_exe` default argument.  This allows us to use
similar logic as `chroot_path`.
@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9550169361

Details

  • 8 of 32 (25.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 55.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_helpers.py 1 2 50.0%
exec_helpers/_ssh_base.py 1 2 50.0%
exec_helpers/api.py 6 14 42.86%
exec_helpers/async_api/api.py 0 14 0.0%
Totals Coverage Status
Change from base Build 9368338757: -0.04%
Covered Lines: 1075
Relevant Lines: 1963

💛 - Coveralls

exec_helpers/api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@penguinolog penguinolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but need to adjust formatting for readability

gjkloosterman and others added 2 commits June 18, 2024 10:44
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9561885796

Details

  • 8 of 33 (24.24%) changed or added relevant lines in 4 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 55.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_helpers.py 1 2 50.0%
exec_helpers/_ssh_base.py 1 2 50.0%
exec_helpers/api.py 6 14 42.86%
exec_helpers/async_api/api.py 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
exec_helpers/async_api/api.py 26 0.0%
Totals Coverage Status
Change from base Build 9368338757: -0.04%
Covered Lines: 1075
Relevant Lines: 1963

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9561887561

Details

  • 8 of 32 (25.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 55.017%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_helpers.py 1 2 50.0%
exec_helpers/_ssh_base.py 1 2 50.0%
exec_helpers/api.py 6 14 42.86%
exec_helpers/async_api/api.py 0 14 0.0%
Totals Coverage Status
Change from base Build 9368338757: -0.04%
Covered Lines: 1075
Relevant Lines: 1963

💛 - Coveralls

@penguinolog penguinolog merged commit 0b32a78 into python-useful-helpers:master Jun 18, 2024
19 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants