-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_iter parameter #80
Conversation
I'll merge and fix changes due to common usability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last changes before merge
fix static check
Pull Request Test Coverage Report for Build 10701335809Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor inconsistencies will be polished before release
What do these changes do?
Introduce
max_iter
parameter. For every iterable, no more thanmax_iter
elements will be loggedAre there changes in behavior for the user?
Long lists will not be fully logged.
Related issue number
Issue #79
Checklist