Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_iter parameter #80

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Conversation

vadim0x60
Copy link
Contributor

What do these changes do?

Introduce max_iter parameter. For every iterable, no more than max_iter elements will be logged

Are there changes in behavior for the user?

Long lists will not be fully logged.

Related issue number

Issue #79

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

logwrap/log_wrap.py Outdated Show resolved Hide resolved
logwrap/repr_utils.py Outdated Show resolved Hide resolved
@penguinolog
Copy link
Collaborator

I'll merge and fix changes due to common usability

Copy link
Collaborator

@penguinolog penguinolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last changes before merge

doc/source/logwrap.rst Outdated Show resolved Hide resolved
doc/source/logwrap.rst Outdated Show resolved Hide resolved
logwrap/log_on_access.py Outdated Show resolved Hide resolved
logwrap/repr_utils.py Outdated Show resolved Hide resolved
logwrap/repr_utils.py Outdated Show resolved Hide resolved
logwrap/log_wrap.py Outdated Show resolved Hide resolved
logwrap/log_wrap.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
logwrap/repr_utils.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10701335809

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 30 of 32 (93.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 95.126%

Changes Missing Coverage Covered Lines Changed/Added Lines %
logwrap/log_on_access.py 7 8 87.5%
logwrap/log_wrap.py 9 10 90.0%
Totals Coverage Status
Change from base Build 10696692091: -0.01%
Covered Lines: 771
Relevant Lines: 820

💛 - Coveralls

Co-authored-by: Alexey Stepanov <penguinolog@users.noreply.github.com>
Copy link
Collaborator

@penguinolog penguinolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor inconsistencies will be polished before release

@penguinolog penguinolog merged commit 17e0f31 into python-useful-helpers:master Sep 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants