Move JS/CSS links to class attributes #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 10, 2020
ocefpaf
reviewed
Nov 10, 2020
| from branca.element import Figure, Element, JavascriptLink, CssLink | ||
|
|
||
|
|
||
| class JSCSSMixin(Element): |
There was a problem hiding this comment.
Thanks! This reduces a lot of code duplication!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to do this before we release. We recently moved the links to external JS and CSS resources to module variables: #1312. This was a good thing. But I was thinking that it would make things much more DRY if we move them to the classes instead, because then we can render them in one place.
I made a mixin class that renders JS and CSS links. I thought about subclassing
MacroElementand using that subclass throughout the code, but I think using a mixin is a bit more clean here.This change allows us to remove duplicated code while still allowing users to replace the JS/CSS links.