Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin older version of leaflet side by side #1732

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

jtmiclat
Copy link
Contributor

Addresses issue raised in #1730

@jtmiclat jtmiclat changed the title Pin version of leaflet side by side Pin version older version of leaflet side by side Feb 26, 2023
@jtmiclat jtmiclat changed the title Pin version older version of leaflet side by side Pin older version of leaflet side by side Feb 26, 2023
@martinfleis
Copy link
Collaborator

Do we know what is going on apart from that the latest version does not work? If it is a bug it should be fixed (either here or there), pinning is only a temporary solution.

@giswqs
Copy link
Contributor

giswqs commented Mar 6, 2023

This is probably a JS issue as the ipyleaflet SplitMap control also has the same issue

jupyter-widgets/ipyleaflet#1066

@martinfleis
Copy link
Collaborator

Interesting. Are you able to pinpoint the source? If it is leaflet or the plugin and report it there? We can pin it here but we need to track the progress to unpin it once resolved in the upstream.

@giswqs
Copy link
Contributor

giswqs commented Mar 6, 2023

It seems the leaflet-side-by-side plugin is the root cause.
digidem/leaflet-side-by-side#47

@giswqs
Copy link
Contributor

giswqs commented Mar 6, 2023

Sent the wrong link. Should be this one: digidem/leaflet-side-by-side#47

@martinfleis
Copy link
Collaborator

Thanks for digging @giswqs!

Copy link
Collaborator

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a temporary fix until the upstream solution is released. Thanks!

@Conengmo Conengmo merged commit 1640792 into python-visualization:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants