Skip to content

Commit

Permalink
Add tests for the logger argument of clients.
Browse files Browse the repository at this point in the history
  • Loading branch information
aaugustin committed Aug 28, 2024
1 parent 15eb223 commit 3171231
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 2 deletions.
8 changes: 8 additions & 0 deletions tests/asyncio/test_client.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import logging
import socket
import ssl
import unittest
Expand Down Expand Up @@ -78,6 +79,13 @@ async def test_disable_keepalive(self):
await asyncio.sleep(2 * MS)
self.assertEqual(client.latency, 0)

async def test_logger(self):
"""Client accepts a logger argument."""
logger = logging.getLogger("test")
async with serve(*args) as server:
async with connect(get_uri(server), logger=logger) as client:
self.assertEqual(client.logger.name, logger.name)

async def test_custom_connection_factory(self):
"""Client runs ClientConnection factory provided in create_connection."""

Expand Down
2 changes: 1 addition & 1 deletion tests/asyncio/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ async def test_logger(self):
"""Server accepts a logger argument."""
logger = logging.getLogger("test")
async with serve(*args, logger=logger) as server:
self.assertIs(server.logger, logger)
self.assertEqual(server.logger.name, logger.name)

async def test_custom_connection_factory(self):
"""Server runs ServerConnection factory provided in create_connection."""
Expand Down
8 changes: 8 additions & 0 deletions tests/sync/test_client.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import socket
import ssl
import threading
Expand Down Expand Up @@ -67,6 +68,13 @@ def test_disable_compression(self):
with connect(get_uri(server), compression=None) as client:
self.assertEqual(client.protocol.extensions, [])

def test_logger(self):
"""Client accepts a logger argument."""
logger = logging.getLogger("test")
with run_server() as server:
with connect(get_uri(server), logger=logger) as client:
self.assertEqual(client.logger.name, logger.name)

def test_custom_connection_factory(self):
"""Client runs ClientConnection factory provided in create_connection."""

Expand Down
2 changes: 1 addition & 1 deletion tests/sync/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def test_logger(self):
"""Server accepts a logger argument."""
logger = logging.getLogger("test")
with run_server(logger=logger) as server:
self.assertIs(server.logger, logger)
self.assertEqual(server.logger.name, logger.name)

def test_custom_connection_factory(self):
"""Server runs ServerConnection factory provided in create_connection."""
Expand Down

0 comments on commit 3171231

Please sign in to comment.