upload logs on e2e failures to help debug #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
reviewed
Aug 19, 2024
.github/workflows/test.yaml
Outdated
| - name: Upload logs for debugging | ||
| if: ${{ failure() }} | ||
| uses: actions/upload-artifact@v4 | ||
| path: e2e-output |
There was a problem hiding this comment.
Do we have any data limits we need to be aware of? There might be some big wheels or sdists in that directory.
There was a problem hiding this comment.
I am not sure i think there is a total limit of 100 GB. Someone experimented and said that greater than 5 GB uploads might start breaking (but i think that is the size of the zip archive): actions/upload-artifact#9
There was a problem hiding this comment.
Could you also the default retention period of artifacts on this repository to be 7 days. It should be somewhere in the repo settings
shubhbapna
force-pushed
the
upload-logs
branch
from
8ae6290 to
23ee9bb
Compare
dhellmann
approved these changes
Aug 19, 2024
|
The retention period is set to 90 days right now. Let's see how that works out, we can adjust if we need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having trouble debugging macos failures and the only way I can do that is via github actions since I don't have access to a mac machine