New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clean method in case var is nan. #164

Merged

s-celles merged 1 commit into python-windrose:master from 15b3:fix_clean_method

Oct 25, 2021

Contributor

15b3 commented Oct 25, 2021

Fix #163.

varmask = var != 0 & np.isfinite(var)

Since the & operator has a higher precedence than the != operator,
the 0 & np.isfinite(var) will be done first, not the var != 0.

Therefore, we need to make the order of calculations explicit.

varmask = (var != 0) & np.isfinite(var)

In addition,

Fixed clean_df function (Similar bug).
Added tests of them.


          Fix clean method in case var is nan.

feb80e9

Member

s-celles commented Oct 25, 2021

CI seems broken but it lgtm

Thanks @15b3 for your contribution

s-celles merged commit e88c176 into python-windrose:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet